Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete substitution for kafka snappy #16798

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Apr 26, 2021

Kafka 2.8.0 removes the MethodHandle usage in CompressionType (see apache/kafka#10123) removing SnappyConstructors as well. As a result the substitution is no longer valid.

The update to Kafka 2.8.0 was done in f8ce993

Fixes #16721

Verified

This commit was signed with the committer’s verified signature.
ozangunalp Ozan Gunalp
Kafka 2.8.0 removes the `MethodHandle` usage in `CompressionType` (see
apache/kafka#10123) removing
`SnappyConstructors` as well.  As a result the substitution is no
longer valid.

The update to Kafka 2.8.0 was done in
quarkusio@f8ce993

Fixes quarkusio#16721
@zakkak
Copy link
Contributor Author

zakkak commented Apr 26, 2021

Marked as Draft until the workflow testing the fix with Mandrel 20.3 completes: https://github.com/graalvm/mandrel/actions/runs/784996770

@zakkak zakkak added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 26, 2021
@zakkak zakkak marked this pull request as ready for review April 26, 2021 10:24
@zakkak
Copy link
Contributor Author

zakkak commented Apr 26, 2021

The tests look OK with in 20.3.
(The REST-client failure is unrelated to this PR and seems like an issue with the CI that needs to be investigated separately)

@gsmet gsmet merged commit a2276ae into quarkusio:main Apr 26, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 26, 2021
@zakkak
Copy link
Contributor Author

zakkak commented Apr 26, 2021

@famod @gsmet shouldn't the CI run the native-image tests for kafka in this PR?

Update: ignore me, they are here https://github.com/quarkusio/quarkus/actions/runs/785202998

@zakkak zakkak deleted the fix-16721 branch April 26, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native] kafka integration tests fail to build with GraalVM 20.3
2 participants